Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support MapOfFinSets for SkeletalFinSets in Julia #158

Merged
merged 1 commit into from
Dec 12, 2022
Merged

support MapOfFinSets for SkeletalFinSets in Julia #158

merged 1 commit into from
Dec 12, 2022

Conversation

mohamed-barakat
Copy link
Member

No description provided.

@mohamed-barakat mohamed-barakat marked this pull request as ready for review December 12, 2022 14:32
@mohamed-barakat mohamed-barakat marked this pull request as draft December 12, 2022 14:42
@mohamed-barakat mohamed-barakat marked this pull request as ready for review December 12, 2022 14:59
@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e5be587) compared to base (54eebdc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1824      1824           
=========================================
  Hits          1824      1824
Impacted Files Coverage Δ
PackageInfo.g 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

zickgraf
zickgraf reviewed Dec 12, 2022
View reviewed changes
gap/Julia.gi Outdated Show resolved Hide resolved
zickgraf
zickgraf reviewed Dec 12, 2022
View reviewed changes
gap/Julia.gi Outdated

##
InstallOtherMethod( MorphismConstructor,
[ IsCategoryOfSkeletalFinSets, IsSkeletalFiniteSet, IsJuliaObject, IsSkeletalFiniteSet ], 1001,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the 1001 (here and below) necessary, and if yes, why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are. Otherwise, the generic methods hit in, probably because of their higher weight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will take us to debugging hell if it breaks (as in homalg-project/homalg_project#277). I think it's time to teach categories about the filters of their object and morphism data. Then we can handle MorphismConstructor in a generic and clean way.

Can you simply redirect the Julia version of MapOfFinSets to the usual version and drop the installations for MorphismConstructor for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@zickgraf zickgraf merged commit 4d4bdd7 into homalg-project:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zickgraf zickgraf zickgraf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamed-barakat @zickgraf