Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install BasisOfExternalHom & CoefficientsOfMorphismWithGivenBasisOfExternalHom #652

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kamalsaleh
Copy link
Member

as primitive methods in additive closure categories. This change significantly improves the performance of these two operations.

@codecov
Copy link

codecov bot commented Apr 4, 2021

Codecov Report

Merging #652 (169079a) into master (39e0986) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   65.09%   64.98%   -0.11%     
==========================================
  Files         321      321              
  Lines       45441    45493      +52     
==========================================
- Hits        29579    29565      -14     
- Misses      15862    15928      +66     
Impacted Files Coverage Δ
FreydCategoriesForCAP/gap/AdditiveClosure.gi 11.49% <0.00%> (-1.03%) ⬇️
CAP/examples/VectorSpacesAllMethods.g 76.92% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e0986...169079a. Read the comment docs.

…alHom

as primitive methods in additive closure category.
@kamalsaleh kamalsaleh force-pushed the BasisOfExternalHomForAdditiveClosures branch from 1008afd to 169079a Compare September 6, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant