This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
WIP: 128 hash table mock #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphinxc0re
suggested changes
Jul 17, 2018
core/src/chain/mod.rs
Outdated
|
|
||
| impl ChainIterator { | ||
|
|
||
| pub fn new<HT: 'static + HashTable> (table: Rc<HashTable>, pair: &Option<Pair>) -> ChainIterator { |
There was a problem hiding this comment.
I think the Iterator should do the same thing as the Chain with the HashTable type.
core/src/chain/mod.rs
Outdated
| let pair = Pair::new(self, entry); | ||
|
|
||
| if !(pair.validate()) { | ||
| return Result::Err(HolochainError::new("attempted to push an invalid pair for this chain")) |
core/src/chain/mod.rs
Outdated
| let next_pair = pair.header().next(); | ||
|
|
||
| if top_pair != next_pair { | ||
| return Result::Err(HolochainError::new( |
core/src/chain/mod.rs
Outdated
| } | ||
| match result { | ||
| Result::Ok(_) => Result::Ok(pair), | ||
| Result::Err(e) => Result::Err(e), |
There was a problem hiding this comment.
Same here: strip the Result::
core/src/hash_table/memory/mod.rs
Outdated
| /// tests for ht.open() | ||
| fn open() { | ||
| let mut ht = test_table(); | ||
| assert_eq!(Result::Ok(()), ht.open()); |
core/src/hash_table/memory/mod.rs
Outdated
| /// tests for ht.close() | ||
| fn close() { | ||
| let mut ht = test_table(); | ||
| assert_eq!(Result::Ok(()), ht.close()); |
sphinxc0re
suggested changes
Jul 18, 2018
core/src/hash_table/pair_meta.rs
Outdated
|
|
||
| // sort by attribute value | ||
| assert_eq!(Ordering::Less, m_1ax.cmp(&m_1ay)); | ||
| assert_eq!(Ordering::Greater, m_1ay.cmp(&m_1ax)); |
There was a problem hiding this comment.
Wouldn't it be better to assert for the actual condition? So e.g.
assert!(m_1ax < m_2ax);
assert_eq!(m_1ax, m_1ax);
assert!(m_2ax > m_1ax);
assert!(m_1ay < m_2ax);There was a problem hiding this comment.
well asserting equality is testing a different thing, as for the others i'm not sure
it makes sense to me that i'm testing cmp but i could add the operators as well to cover both
…-table-mock # Conflicts: # core/src/agent/mod.rs # core/src/nucleus/ribosome.rs
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
==========================================
+ Coverage 84.09% 85.89% +1.8%
==========================================
Files 15 16 +1
Lines 660 773 +113
==========================================
+ Hits 555 664 +109
- Misses 105 109 +4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #128
fixes #35
followup: