New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Alt parser #414

Closed

Huy-DNA wants to merge 161 commits into master from alt-parser

Contributor

Huy-DNA commented Aug 1, 2023 •

edited

Loading

Summary

Add an alternative hand-written dbml parser (not integrated yet).
How the parser's currently work: https://dbml-explorer-demo-1.vercel.app/
Next PR: 2. Simple Report serializer #419

Issue

Lasting Changes (Technical)

Add an alternative dbml parser.

Checklist

Please check directly on the box once each of these are done

Documentation (if necessary)
Tests (integration test/unit test)
Integration Tests Passed
Code Review

Huy-DNA added 2 commits

August 1, 2023 09:39


          feat: add an alternative dbml parser

c0286e2


          test: add dbml tests

1bfb755

Huy-DNA requested a review from phuongduyphan

August 1, 2023 02:48

Contributor

NQPhuc commented Aug 2, 2023

Please ensure all CI tests passed

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

packages/dbml-core/src/parse/dbml/src/lib/utils.ts Show resolved Hide resolved

Collaborator

phuongduyphan commented Aug 2, 2023

This PR is quite large @Huy-DNA, next time suggest we create multiple smaller PRs (i.e one for lexer, one for parser)

Collaborator

phuongduyphan commented Aug 2, 2023

Also pls help me benchmark the new parser with the old pegjs one

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/lexer/lexer.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/result.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/result.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/errors.ts Outdated Show resolved Hide resolved

Huy-DNA and others added 9 commits

August 2, 2023 20:59


          refactor: unify all operators under a single token kind

fa85b8d


          style: trivial fixes to styling

46aeea6


          refactor: extract logic in lex to scanTokens

9f50d0b


          refactor: extract common logic of lexing string-like token

17bdba1


          fix: lexing unicode escape sequence

05504f1


          test: update tests

c319a96


          doc: add comments to lexer's gatherTrivia

ea32a24


          feat: make Result error generic

a822e2d


          doc: add comment to Result

29e3b32

Contributor Author

Huy-DNA commented Aug 3, 2023

Also pls help me benchmark the new parser with the old pegjs one

I have performed a cursory benchmark for the two:
For the following program:

Running it for about ten times, the total time of:

The pegjs one:
The new one:

Contributor Author

Huy-DNA commented Aug 3, 2023

Benchmark results:

18k
- Pegjs (5 times):
- New one (10 times):
25k
- Pegjs (5 times):
- New one (10 times):

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/parser/parser.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/parser/parser.ts Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/parser/parser.ts Outdated Show resolved Hide resolved

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/parser/parser.ts Outdated Show resolved Hide resolved


          feat: add support for <> & change <OP> to <op>

8012f6e

phuongduyphan reviewed

View reviewed changes

packages/dbml-core/src/parse/dbml/src/lib/parser/parser.ts Outdated Show resolved Hide resolved

Huy-DNA and others added 28 commits

September 28, 2023 12:26


          Merge pull request #443 from holistics/fix-lexer-single-line-comment

51eb653

fix: single-line-comments was consuming newlines


          Merge pull request #444 from holistics/fix-log-error-on-missing-alias

e21c145

fix: missing alias was not logged in parser


          fix: bug in interpreter alias kind

59ffc57


          Merge pull request #445 from holistics/fix-interpreter-alias-kind

fix: bug in interpreter alias kind


          fix: add partial-parsing feat

ab1337d


          fix: drop binding requests & revamp binder

7be6eb0


          fix: revamp compiler & autosuggestions

d5f58de


          fix: ignore simple body of the form elem decl

0a2f26b


          fix: rename owner to parent for clarity

7bdadb3


          fix: bug in member & attribute suggestions

d8b7308


          fix: bug in member suggestions & space preprending

40f6620


          feat: support keywords in binder

95fb9cd


          feat: support complex tuples in ref

4f17db4


          fix: serialization error

7316ede


          fix: mismatch in interpreted rawDb output

80965fc


          feat: add autosuggestion support in ref tuple

d041158


          fix: normalize noteContent in interpreter

2bfdf03


          Merge branch 'revamp-binder' into revamp-autosuggestions

3de9075


          Merge pull request #424 from holistics/parser-binder

8d4722a

6. Parser binder


          Merge pull request #439 from holistics/parser-add-support-for-editor

bcab81a

11. Add support for editor


          Merge pull request #447 from holistics/revamp-parser

d40c802

12. add partial parsing capability


          Merge pull request #448 from holistics/revamp-binder

8c15cdc

13. Revamp binder


          Merge branch 'alt-parser' into parser-interpreter

21a0343


          Merge pull request #454 from holistics/parser-interpreter

5c98b50

Merge interpreter into alt-parser


          Merge pull request #455 from holistics/parser-baseElementValidator

b992374

Merge validator into alt-parser


          Merge pull request #456 from holistics/revamp-parser

b06c814

merge revamp-parser into alt-parser


          Merge pull request #457 from holistics/revamp-autosuggestions

bb63de5

merge revamp-autosuggestions into alt-parser


          fix: remove redundant model_structure

9897b55

Huy-DNA closed this

Huy-DNA deleted the alt-parser branch

February 26, 2024 02:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet