Skip to content

Commit

Permalink
Merge pull request #39 from ppeble/fix_fedex
Browse files Browse the repository at this point in the history
Fix fedex definition mistake in day_after_thanksgiving custom method
  • Loading branch information
ppeble authored Apr 28, 2017
2 parents d93419c + 5fa47e1 commit 5525ee6
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 2 deletions.
46 changes: 45 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,50 @@
# Holiday definitions

## 9/15/2016
## 1.5.1

* Fix error in `fedex` custom method `day_after_thanksgiving`

## 1.5.0

* Update NYSE to fix observed NYD
* Use native language for KR
* Use native language for VI
* Update AU definitions for accuracy
* Update KR definitions to include lunar holiday calculations
* Add VI definitions

## 1.4.0

* :au - corrects holidays for certain regions
* :vi - reports holiday names in Vietnamese instead of English, adds 1 additional holiday (Giỗ tổ Hùng Vương)

## 1.3.0

* Add Travis badge to README
* Add Tunisian holidays
* Correct various Australian holidays
* Updates various German regions to be more accurate
* Changed 'nf' to 'nl' for Newfoundland & Labrador
* Changed 'yk' to 'yt'kkk

## 1.2.1

* Fix syntax and test errors in au and ca def tests

## 1.2.0

* updates jp defs to fix 'Foundation Day' name
* Fix ca defs for observed holidays
* Update au defs to have Christmas and Boxing Day for all of Australia instead of just individual territories
* Update ie defs to consolidate "St Stephen's Day" to use common method instead of custom method

## 1.1.0

* Add HK definitions
* Add KR definitions
* Fix small bug in JP definitions

## 2016 1.0.0

Initial creation of this repository

Expand Down
2 changes: 1 addition & 1 deletion fedex.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ methods:
day_after_thanksgiving:
arguments: year
source: |
Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 11, 4, 4) + 1
Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 11, 4, 4) + 1
tests: |
{Date.civil(2015,1,1) => 'New Year\'s Day',
Date.civil(2015,5,25) => 'Memorial Day',
Expand Down

0 comments on commit 5525ee6

Please sign in to comment.