up

holgerlembke · Mar 22, 2024 · 84e7acf · 84e7acf
1 parent 8ae9678
commit 84e7acf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/st7567sfGK.cpp b/src/st7567sfGK.cpp
@@ -462,16 +462,14 @@ void st7567sfGKBase::textflow(textflow_t flow) {
 //**************************************************************************************************************************************
 //**************************************************************************************************************************************
 //**************************************************************************************************************************************
-inline size_t st7567sfGK::write(uint8_t value) {
+size_t st7567sfGK::write(uint8_t value) {
  writechar(textinfo.x, textinfo.y, value, colorwhite);
  return 1; // assume sucess
 }
 
 //**************************************************************************************************************************************
 //**************************************************************************************************************************************
 //**************************************************************************************************************************************
-st7567sfGKAdafruit::~st7567sfGKAdafruit() {}
-
 //**************************************************************************************************************************************
 // copy from Adafruit_GFX.cpp
 void st7567sfGKAdafruit::setFont(const GFXfont* f) {
@@ -635,7 +633,7 @@ void st7567sfGKAdafruit::writecharAF(uint8_t& x, uint8_t& y, char c,
 }
 
 //**************************************************************************************************************************************
-inline size_t st7567sfGKAdafruit::write(uint8_t value) {
+size_t st7567sfGKAdafruit::write(uint8_t value) {
  if (!gfxFont) {
  writechar(textinfo.x, textinfo.y, value, colorwhite);
  } else {

diff --git a/src/st7567sfGK.h b/src/st7567sfGK.h
@@ -63,6 +63,10 @@ Screen layout:
  remove D2 + D1. #1 and #6 from the right, small black blobs.
 
  History
+ + 0.4.5
+ - removed "virtual ~st7567sfGKAdafruit();" added in 0.4.4
+ - removed inline from both virtual functions write(uint8_t value)
+ (https://github.com/holgerlembke/st7567sfGK/issues/1)
  + 0.4.4
  - font.cpp replaced reference to <avr/pgmspace.h> with <Arduino.h>
  - added "virtual ~st7567sfGKAdafruit();" to satisfy stm32 arm compiler
@@ -190,7 +194,6 @@ class st7567sfGK : public st7567sfGKBase, public Print {
 class st7567sfGKAdafruit : public st7567sfGKBase, public Print {
  public: //---------
  st7567sfGKAdafruit() { tfofs = 0; }
- virtual ~st7567sfGKAdafruit();
  using Print::write;
  void setCursor(uint8_t x, uint8_t y) {
  textinfo.x = x;