Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate terraform-libvirt-provider support virtual machine provisioning #68

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rgielen
Copy link
Contributor

@rgielen rgielen commented Oct 18, 2020

This pull request adds support for provisioning hobbykube clusters based on KVM / QEMU virtual machines, utilizing terraform-libvirt-provider.

The module is fully functional, reasonably configurable and comes with documentation and example configuration placed in the module directory.

Hopefully others fid it useful.
Feedback is of course highly welcome.

@rgielen
Copy link
Contributor Author

rgielen commented Oct 18, 2020

First finding: documentation lacks information that libvirt must be present on the provisioning machine, along with instructions how to set this up on Linux / MacOS

@pstadler
Copy link
Member

I never said thank you for opening this pull request and I'm sorry about that, because you definitely put a lot of work into it. Unfortunately I have no setup to test this. As many people simply leave for good after submitting a PR, I'm wondering whether you'd want to create a repository with this module yourself and I'd put a section in the README here. What do you think?

@rgielen
Copy link
Contributor Author

rgielen commented May 25, 2021

No worries, I know that keeping up with PRs can be very challenging, as is keeping PR branches up to date with origin master.
To further discuss how to deal with this PR, I'd need to rebase and verify it again, which I'm supposed to do as soon as time permits. I'm using this feature regularly, as it allows me to trade a Rasberry Pi cluster for a NUC+i9 when setting up multi node test clusters.
I'd also like to describe the setup of a minimal test system (Linux host with KVM/QEMU support) in the docs. Basically it should work not only with a bare metal Linux box, but also with VMWare, VirtualBox, MultiPass or even WSL2.
Once I've done my homework, I'll check back to further discuss wether this could be valuable for the original project, if you're ok with this.

@rgielen rgielen force-pushed the feature/provider-libvirt branch from 6f1c743 to dd86886 Compare May 30, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants