Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #2126: Reading the values from 'ExpandedCapacity' of XML file 'arenadetails.xml' #2127

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

sgcr
Copy link
Collaborator

@sgcr sgcr commented Aug 21, 2024

  1. changes proposed in this pull request:
  1. src/main/resources/release_notes.md ...
  • does not require update
  1. [Optional] suggested person to review this PR @wsbrenk

@sgcr
Copy link
Collaborator Author

sgcr commented Aug 21, 2024

Hi @wsbrenk and thanks for approving :)

Do you think the two commit should be squashed?
I separated the changes for the code review to show that the refactoring of XMLArenaParser does not change the tests.

@wsbrenk wsbrenk merged commit adad97a into ho-dev:master Aug 23, 2024
1 check passed
@sgcr sgcr deleted the fix/bug-2126-reading-expanded-capacity branch August 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants