Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1905 load skill changes from player table #1974

Merged
merged 2 commits into from
Dec 5, 2023
Merged

#1905 load skill changes from player table #1974

merged 2 commits into from
Dec 5, 2023

Conversation

wsbrenk
Copy link
Collaborator

@wsbrenk wsbrenk commented Dec 5, 2023

  1. changes proposed in this pull request:

  2. src/main/resources/release_notes.md ...

  • has been updated
  • does not require update
  1. [Optional] suggested person to review this PR @tychobrailleur

tychobrailleur
tychobrailleur approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@tychobrailleur tychobrailleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great cleanup, and I like how you build the list of skill changes from the player's history.

@wsbrenk wsbrenk merged commit 0d04f57 into ho-dev:master Dec 5, 2023
1 check passed
@wsbrenk wsbrenk deleted the #1905 branch December 5, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychobrailleur tychobrailleur tychobrailleur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsbrenk @tychobrailleur