Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove the skillup table #1905

Closed
wsbrenk opened this issue Aug 5, 2023 · 3 comments
Closed

[FEATURE] Remove the skillup table #1905

wsbrenk opened this issue Aug 5, 2023 · 3 comments
Assignees
@wsbrenk
Labels
status: needs test might be fixed, needs test before closing
Milestone
8.0

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Aug 5, 2023

The table of the skillups is a redundancy to the player table where the skill levels of each download (hrf) are stored.
@wsbrenk wsbrenk added this to the 8.0 milestone Aug 5, 2023
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Aug 5, 2023

recalculation of skillups will no longer be necessary when they were loaded from the player table.

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Nov 28, 2023

A lag function is not available in hsqldb

@wsbrenk wsbrenk self-assigned this Dec 3, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 5, 2023
@wsbrenk
ho-dev#1905 load skill changes from player table
1ef266c
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 5, 2023
@wsbrenk
ho-dev#1905 beautify
02265df
@wsbrenk wsbrenk mentioned this issue Dec 5, 2023
Merged
2 tasks
wsbrenk added a commit that referenced this issue Dec 5, 2023
@wsbrenk
#1905 load skill changes from player table (#1974)
0d04f57 
* #1905 load skill changes from player table

* #1905 beautify
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 5, 2023
@wsbrenk
ho-dev#1905 Matchdetails region Id is nullable
e16b57e
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 5, 2023
@wsbrenk
ho-dev#1905 Matchdetails region Id is nullable
06dca9f
wsbrenk added a commit that referenced this issue Dec 7, 2023
@wsbrenk
#1975 Matchdetails region Id is nullable (#1976)
d16e59a 
* #1905 Matchdetails region Id is nullable

* #1905 Matchdetails region Id is nullable
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Dec 8, 2023
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Dec 9, 2023

current solution does not use the skillup table anymore.
TODO: if tests will be successful dbupdater should drop the database table.

wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 25, 2023
@wsbrenk
ho-dev#1905 remove database table SPIELERSKILLUP
742af33
@wsbrenk wsbrenk mentioned this issue Dec 25, 2023
Merged
2 tasks
wsbrenk added a commit that referenced this issue Jan 6, 2024
@wsbrenk
#1905 remove database table SPIELERSKILLUP (#2005)
e5c9195
@wsbrenk wsbrenk closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsbrenk wsbrenk

Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
1 participant
@wsbrenk