refactor: Use constant for the plus sign and use ComparableUtils

ho-dev · Sep 3, 2024 · 9d5f114 · 9d5f114
1 parent 4e26627
commit 9d5f114
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/main/java/tool/arenasizer/LabelWithSignedNumber.java b/src/main/java/tool/arenasizer/LabelWithSignedNumber.java
@@ -13,9 +13,12 @@
 
 import static java.math.BigDecimal.ZERO;
 import static org.apache.commons.lang3.StringUtils.EMPTY;
+import static org.apache.commons.lang3.compare.ComparableUtils.is;
 
 class LabelWithSignedNumber extends JLabel {
 
+    private static final String PLUS_SIGN = "+";
+
     private final String notAvailableString = HOVerwaltung.instance().getLanguageString("ls.general_label.not_available_abbreviation");
 
     public LabelWithSignedNumber(String text, int horizontalAlignment) {
@@ -62,12 +65,12 @@ private static Color getColorFromCompareResult(int compareResult) {
     }
 
     private static String formatNumberWithSign(NumberFormat numberformat, int number) {
-        final String prefix = (number > 0) ? "+" : EMPTY;
+        final String prefix = (number > 0) ? PLUS_SIGN : EMPTY;
         return prefix + numberformat.format(number);
     }
 
     private static String formatNumberWithSign(BigDecimal percentage) {
-        final String prefix = (percentage.compareTo(ZERO) > 0) ? "+" : EMPTY;
+        final String prefix = is(percentage).greaterThan(ZERO) ? PLUS_SIGN : EMPTY;
         return prefix + percentageValueString(percentage);
     }