Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user profile image not reflecting on nav bar #1530

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

d-a-ve
Copy link
Collaborator

@d-a-ve d-a-ve commented Dec 13, 2023

you can check this one that was used for the previous cohort

Fixes Issue/Linear Ticket

  • Linear Ticket: Fixes ID-#PORT-12

Changes proposed

  1. Removed the default gray box for user image on nav bar and made it reflect the user's image
  2. Changed the default user image to show user's initials if user has not set image

Check List (Check all the applicable boxes)

🚨Please review the [style guide for contributing](add link here) and [guidelines for contributing](add link here) to this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/ Videos

USER IMAGE SHOWING ON NAVBAR
Screenshot 2023-12-14 at 00 03 35

NEW DEFAULT IMAGE PLACEHOLDER
Screenshot 2023-12-14 at 00 04 10

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zuriportfolio-frontend ✅ Ready (Inspect) Visit Preview Dec 13, 2023 11:17pm

@Homoakin619 Homoakin619 self-requested a review December 14, 2023 01:13
@Homoakin619 Homoakin619 merged commit 42c4719 into dev Dec 14, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants