Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HNG-17-success-page-for-magic-link #285

Conversation

oyin-systems
Copy link
Collaborator

@oyin-systems oyin-systems commented Jul 21, 2024

Description

Closes #17

Changes proposed

What were you told to do?

Title: Authentication Page -> Success page for magic link #17
Acceptance Criteria:
Responsive across all screen sizes (desktop, tablet and mobile)
Write tests for your code.
Use components where necessary (header, footer, buttons, modal and so on)

What did you do?

I created a new page (Success.tsx) and made it available as a route. I also had to create header and footer components since it was needed to complete the page. Then I performed tests according to the instructions.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Desktop
desktop
Tablet
tablet
Mobile
mobile

Link to Figma File

Design

@oyin-systems oyin-systems requested a review from psalm987 July 21, 2024 15:49
@oyin-systems oyin-systems requested a review from chumex412 July 21, 2024 16:00
@psalm987
Copy link
Collaborator

psalm987 commented Jul 21, 2024

the endpoint of the page should be /auth/login/email-link/success according to the routing guide, not /magic-link

@oyin-systems
Copy link
Collaborator Author

the endpoint of the page should be /login/email-link/success according to the routing page, not /magic-link

Yes, it is. the magic-link is the old one and I've deleted it. I already changed it to point to auth/login/email-link/success. Check the screenshot below:
abcd

@shalomtaiwo shalomtaiwo requested review from shalomtaiwo and removed request for psalm987 and chumex412 July 21, 2024 16:14
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@shalomtaiwo shalomtaiwo merged commit 2219bed into hngprojects:dev Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Authentication Page -> Success page for magic link
3 participants