-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/hng 45 create comment box component #267
Feat/hng 45 create comment box component #267
Conversation
The code you want to send has lint errors. Run |
@psalm987 Okay. Let me fix that and push again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all comments and be back asap, add your component at the bottom of guide's page.tsx and record a video to be attached to this PR. also test after all is done and pulled from upstream
Alright lemme do that asap |
The guide's page.tsx u mentioned is it the home page of the app. 'Coz on the current project there is no page.tsx file. Or should I create one and add my component on it? Plz reply me so I have more clarification on what to change. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that you used npm not pnpm
Also, you have a component can you put your component to view under guide's pages.tsx and remove that route you did
Okay lemme fix that real quick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are expected to use lucide icons not svg exports
5e3a06e
to
93b23ee
Compare
[FEAT] Comments > comment box #45
Work on the comment box component to be added to the comments page in the HNG-Boilerplate-Remix project.
Some of the task I worked on and implemented:
Changes Implemented - UI
-- Created a new "CommentBox.tsx" file representing the reusable comment box component
-- Deleted and Switched from using CSS Modules for Styling to using TailwindCSS
-- Implemented all the appropriate styling on the component based on the provided figma design using tailwindCSS
-- Imported and rendered the previously created "CommentBox.tsx" component on the comments route
Testing
Output
Video (to be attached to PR as asked in change request by reviewer)
Screen.Recording.2024-07-21.at.15.09.17.1.mov