Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the organization sign up page as shown in the design for issue #15 #256

Merged
merged 8 commits into from
Jul 21, 2024

Conversation

itsAakashz
Copy link
Collaborator

@itsAakashz itsAakashz commented Jul 21, 2024

Description

Closes #issue_number_here
15

Changes proposed

What were you told to do?

I have told to Implement the organization sign up page as shown in the design for issue #15

Authentication Page -> Sign up Organization

What did you do?

This PR adds a signup form for creating an organization account. It includes the following changes:

Form Fields and Validation:

Created an interface FormData to define the types for the form fields.
Added an interface FormErrors to handle validation error messages.
Implemented the validateForm function to validate form data and return error messages if fields are missing or incorrect.
Added a client-side validation for the email field to remove errors as the user types.
Form Components:

Used Form, Label, Input, and Button components from @remix-run/react and custom components for UI elements.
Created a responsive form layout with various input fields such as company name, email, industry, organization type, country, state, address, and LGA.
Form Submission Handling:

Implemented the handleSubmit function to validate the form data before submission.
Used the useActionData hook to handle server-side validation errors and display them on the form.
Styling:

Applied conditional styling to input fields to indicate validation states.
Ensured the form is responsive and user-friendly on both desktop and mobile devices.

I created OrganizationSignUpPage.tsx inside Route folder

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

snap
mobile

@chumex412
Copy link
Contributor

chumex412 commented Jul 21, 2024

You implementation is different from design and no screenshot of mobile view. Look for the navbar component and integrate it

@itsAakashz
Copy link
Collaborator Author

itsAakashz commented Jul 21, 2024

I have updated mobile screenshot and still there no footer and header components so i did't included. There was so much confusion about everything so i came up with this design and it matches so much to design in figma. Please merge it if any issue will occurs then i will fix it in next future.

@auztincodes auztincodes removed their request for review July 21, 2024 14:08
@psalm987
Copy link
Collaborator

The header and footer have been added. Implement and make updates.

@psalm987 psalm987 added the changes requested This is a PR that requires changes before it is merged label Jul 21, 2024
@itsAakashz
Copy link
Collaborator Author

itsAakashz commented Jul 21, 2024

i have already implemented header and footer in my last commit

@itsAakashz itsAakashz requested a review from shalomtaiwo July 21, 2024 16:34
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly what is the space doing between the navbar and the signUp.

Also, what is going on with the padding???

image

@shalomtaiwo shalomtaiwo merged commit bb3e288 into hngprojects:dev Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This is a PR that requires changes before it is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants