Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/92 implement no search found #255

Closed
wants to merge 3 commits into from
Closed

Feat/92 implement no search found #255

wants to merge 3 commits into from

Conversation

Azikenp
Copy link
Collaborator

@Azikenp Azikenp commented Jul 21, 2024 •
edited
Loading

Fixed the "no search found " issue 92 from the tasks

Closes #92

Made some fixes to es lint errors in pulled dev branch

What were you told to do?

What did you do?

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • [x ] My code follows the code style of this project.
  • [x ] This PR does not contain plagiarized content.
  • [ x] The title and description of the PR is clear and explains the approach.
  • [ x] I am making a pull request against the dev branch (left side).
  • [x ] My commit messages styles matches our requested structure.
  • [x ] My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

object

@Azikenp
Copy link
Collaborator Author

Azikenp commented Jul 21, 2024

i probably made a mistake filling the markdown

@Azikenp
Copy link
Collaborator Author

Azikenp commented Jul 21, 2024

lint pass

@Azikenp Azikenp requested a review from KehindeDaniels July 21, 2024 09:24
@chumex412
Copy link
Contributor

Please resolve the conflict

@Azikenp Azikenp closed this by deleting the head repository Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KehindeDaniels KehindeDaniels Awaiting requested review from KehindeDaniels

@abdulmalikyusuf abdulmalikyusuf Awaiting requested review from abdulmalikyusuf

@abel-otegbola abel-otegbola Awaiting requested review from abel-otegbola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] External Dynamic Pages > Career Page > Implement no search found
2 participants
@Azikenp @chumex412