Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create reusable button component #251

Conversation

Xcoder2023
Copy link
Collaborator

@Xcoder2023 Xcoder2023 commented Jul 21, 2024

Description

Closes #29

Changes proposed

Create reusable Button components with customizable features. The components should also support an optional href prop to convert it into a link

created a reusable button component that can be modified to match the design pattern of any component. also included is the samples and guide on how it can be modified/used depending on the button design of a particular component that may need it. the use/guide sample are contained in ui/customButton.tsx and guide/ButtonUsage.md and guide/usebutton.tsx (for ui view) respectively. no file changed, no dependency installed

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • [X ] My code follows the code style of this project.
  • [ X] This PR does not contain plagiarized content.
  • [X ] The title and description of the PR is clear and explains the approach.
  • [ X] I am making a pull request against the dev branch (left side).
  • [ X] My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screenshot 2024-07-21 015147

attached above is the screenshot of the button component implemented

@Xcoder2023 Xcoder2023 force-pushed the feat/ISSUE-29-create-reusable-button-component branch 2 times, most recently from 30bee76 to aefbf43 Compare July 21, 2024 06:27
@Xcoder2023 Xcoder2023 requested a review from psalm987 July 21, 2024 13:33
Copy link
Collaborator

@SirhmVFX SirhmVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@SirhmVFX SirhmVFX merged commit 1fa24cb into hngprojects:dev Jul 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Components → Button
2 participants