feat/HNG-33-cookie-consent-settings #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolve conflicts and attach screenshots of desktop and mobile view |
|
I have removed the CoookieConsent.tsx component from app/routes/_index.tsx i believe this will resolve the conflict. |
|
|
abiona01
reviewed
Jul 21, 2024
|
|
||
| } | ||
|
|
||
| *{ |
There was a problem hiding this comment.
This is already in global css
| @@ -0,0 +1,69 @@ | |||
| import React, {useState} from "react"; | |||
There was a problem hiding this comment.
You don't need to import react, just useState is fine
Comment on lines
+35
to
+40
| onKeyDown={(e) => { | ||
| if (e.key === 'Enter' || e.key === ' ') { | ||
| toggleExpand(); | ||
| e.preventDefault() | ||
| } | ||
| }} |
There was a problem hiding this comment.
Extract this into a function, then call it here
| @@ -0,0 +1,118 @@ | |||
| import React, { useState } from 'react'; | |||
There was a problem hiding this comment.
Don't import the entire React, just import what you need, e.g FC
Comment on lines
+37
to
+41
| if (e.key === 'Enter' || e.key === ' ') { | ||
| onToggle(); | ||
| e.preventDefault() | ||
| } | ||
| }} |
|
Also @Kwasako you have conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented Cookie Consent Modal
Closes #33
Changes proposed
What were you told to do?
Implement all sections of the cookie consent settings
What did you do?
Implemented all sections of the cookies consent settings designs.
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos