Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hng 35 about page #241

Closed

Conversation

Justjoseph0
Copy link
Collaborator

Description

Closes #issue_number_35

Changes proposed

What were you told to do?

Fix ESLint error related to unescaped characters in About.tsx.
Add a custom background image to the project.

What did you do?

  • Added Bgmobile.png,background.png and all the about pages-images to the public/images/ directory.
  • Updated tailwind.config.js to include a custom background image utility.
  • Applied the new background image class to the executive-team-section in about.tsx.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • [ X] This PR does not contain plagiarized content.
  • [X ] The title and description of the PR is clear and explains the approach.
  • [ X] I am making a pull request against the dev branch (left side).
  • [ X] My commit messages styles matches our requested structure.
  • [X ] My code additions will fail neither code linting checks nor unit test.
  • [X
Screenshot 2024-07-20 at 2 59 58 PM ] I am only making changes to files I was requested to.

Screenshots/Videos

@Justjoseph0 Justjoseph0 requested a review from Samadeen July 20, 2024 22:40
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use global color styles

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the colors are not in the global css

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're not allowed to change config files reach a mentor for styles needed

@Justjoseph0 Justjoseph0 requested a review from SirhmVFX July 20, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants