Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delete member modal #232

Conversation

monyasau
Copy link
Collaborator

Description

Closes #8

Changes proposed

What were you told to do?

I was told to implement the delete member modal

What did you do?

I implemented the delete member modal according to the figma design with requested functionalities using the available "alert-dialog" from shadCN without changing any other files.

  • I implemented the "Delete Member" modal with the specified text and buttons
  • I ensured the modal closes when clicking outside it or the times button
  • I ensured overlay opacity is applied to the parent page when the modal is open
  • I ensured the modal follows the brand's design guidelines
  • I made sure the modal is responsive

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screenshot 2024-07-20 214810

Copy link

@oreoluwa212 oreoluwa212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you worked on a modal and I am seeing BlogCards.tsx, make it make sense please. Use shadcn or I'm reassigning, and if you dont created your subfolder in that components folder, home o

@oreoluwa212
Copy link

your lint checks failed
attach proper video of your component working
and screenshot of pnpm and lint tests

@monyasau
Copy link
Collaborator Author

@oreoluwa212 the blogCard had linting issues in it so i ran pnpm lint --fix also i used shadCN

@monyasau monyasau deleted the feat/HNG-8-implement-delete-member-modal branch July 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Organization settings Manage Members > Implement this Delete Member modal
2 participants