-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/HNG-118-external-static-pages-footer-component #229
feat/HNG-118-external-static-pages-footer-component #229
Conversation
…kyusuf/hng_boilerplate_remix into feat/53-questions-form
…kyusuf/hng_boilerplate_remix into feat/53-questions-form
…remix into feat/53-questions-form
…kyusuf/hng_boilerplate_remix into feat/53-questions-form
… functionality-final)
…e-consent-component
…remix into feat/HNG-28-floating-footer-cookie-consent-component
…https://github.com/KehindeDaniels/hng_boilerplate_remix into feat/HNG-28-floating-footer-cookie-consent-component
…remix into feat/HNG-28-floating-footer-cookie-consent-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve conflict
you're not to edit the package.json
run pnpm lint:fix
…ttps://github.com/Frankpesta/hng_boilerplate_remix into feat/HNG-118-external-static-pages-footer-component
The files changed don't correspond to the description of the PR, there's no figma link on the description, plus there's already a footer component in the UI folder, pull and resolve. |
Open a new branch and make your corrections then make a new PR, we cant verify 53 file changes, in case you might have a breaking change in it |
Description
Create the footer component for external static pages
**Closes #118 **
Changes proposed
What were you told to do?
Create Footer Component for the External static Pages
What did you do?
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos