Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HNG-118-external-static-pages-footer-component #229

Closed
wants to merge 88 commits into from
Closed

feat/HNG-118-external-static-pages-footer-component #229

wants to merge 88 commits into from

Conversation

Frankpesta
Copy link
Contributor

Description

Create the footer component for external static pages

**Closes #118 **

Changes proposed

What were you told to do?

Create Footer Component for the External static Pages

What did you do?

  • Created a footer component in the components/ui folder
  • Added the footer component to the root.tsx file thus ensuring availability across all static pages
  • Created an icons folder in the Public folder
  • I added the necessary icons for the footer component

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

image
image

abdulmalikyusuf and others added 30 commits July 19, 2024 18:00
…remix into feat/HNG-28-floating-footer-cookie-consent-component
…remix into feat/HNG-28-floating-footer-cookie-consent-component
Copy link
Collaborator

@SirhmVFX SirhmVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflict

you're not to edit the package.json

run pnpm lint:fix

@psalm987
Copy link
Collaborator

psalm987 commented Jul 21, 2024

The files changed don't correspond to the description of the PR, there's no figma link on the description, plus there's already a footer component in the UI folder, pull and resolve.

@psalm987 psalm987 requested review from SirhmVFX and psalm987 July 21, 2024 13:54
@psalm987
Copy link
Collaborator

Open a new branch and make your corrections then make a new PR, we cant verify 53 file changes, in case you might have a breaking change in it

@psalm987 psalm987 closed this Jul 21, 2024
@Frankpesta Frankpesta deleted the feat/HNG-118-external-static-pages-footer-component branch July 21, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] External Static Pages > Footer component
10 participants