Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/HNG-71-account-deactivation-by-user-email-template #228

Merged
merged 10 commits into from
Jul 21, 2024

Conversation

atonya-bravin
Copy link
Contributor

This is the deactivation email template that is implemented as a component and takes in an object deactivationDetails that includes;

name => the name of the user
email => the email of the user
dateTime => the date and time of deactivation

**Closes #71 **

Changes proposed

What were you told to do?

I was to implement a deactivation email template

#71

What did you do?

I downloaded and later uploaded the assets in the figma file
I created a deactivation email tepmplates folder which I included the component file and the test file

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

These are all the assets that I used in the deactivation email template

see: hngprojects#71
The deactivation email template is composed as a component and is
reciving an object called deactivationDetails that contains;

name => the name of the user
email => the email of the user
dateTime => the date and time of deactivation

see: hngprojects#71
This is the unit test related to the deactivation email template

see: 71
@atonya-bravin atonya-bravin changed the title Deactivation email template feat-HNG-71-account-deactivation-by-user-email-template Jul 21, 2024
@atonya-bravin atonya-bravin changed the title feat-HNG-71-account-deactivation-by-user-email-template feat/HNG-71-account-deactivation-by-user-email-template Jul 21, 2024
Copy link
Collaborator

@SirhmVFX SirhmVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run pnpm lint:fix

to fix lint issues and push again

atonya-bravin and others added 7 commits July 21, 2024 16:58
This is a fix to the review done in the previous PR(228) the changes
make sure that pnpm lint:fix passes the checks.

see: hngprojects#71
The eslint disablers have been removed but they can cause no issues in
the running of the program. The test file is also removed.

fix: hngprojects#71
changed the eventlistner from arrow function to eventlistner.

fix: 71#
changed the eventlistner from arrow function to eventlistner.

fix: hngprojects#71
@atonya-bravin atonya-bravin requested a review from SirhmVFX July 21, 2024 15:01
@shalomtaiwo shalomtaiwo requested review from shalomtaiwo and removed request for SirhmVFX July 21, 2024 16:12
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@shalomtaiwo shalomtaiwo merged commit 2a68975 into hngprojects:dev Jul 21, 2024
1 check passed
@atonya-bravin
Copy link
Contributor Author

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: AUTHENTICATION -> EMAIL TEMPLATE -> Account Deactivation by User Template
3 participants