-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/HNG-71-account-deactivation-by-user-email-template #228
Merged
shalomtaiwo
merged 10 commits into
hngprojects:dev
from
atonya-bravin:deactivation_email_template
Jul 21, 2024
Merged
feat/HNG-71-account-deactivation-by-user-email-template #228
shalomtaiwo
merged 10 commits into
hngprojects:dev
from
atonya-bravin:deactivation_email_template
Jul 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all the assets that I used in the deactivation email template see: hngprojects#71
The deactivation email template is composed as a component and is reciving an object called deactivationDetails that contains; name => the name of the user email => the email of the user dateTime => the date and time of deactivation see: hngprojects#71
This is the unit test related to the deactivation email template see: 71
atonya-bravin
changed the title
Deactivation email template
feat-HNG-71-account-deactivation-by-user-email-template
Jul 21, 2024
atonya-bravin
changed the title
feat-HNG-71-account-deactivation-by-user-email-template
feat/HNG-71-account-deactivation-by-user-email-template
Jul 21, 2024
SirhmVFX
previously requested changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run pnpm lint:fix
to fix lint issues and push again
This is a fix to the review done in the previous PR(228) the changes make sure that pnpm lint:fix passes the checks. see: hngprojects#71
The eslint disablers have been removed but they can cause no issues in the running of the program. The test file is also removed. fix: hngprojects#71
…ya-bravin/hng_boilerplate_remix into deactivation_email_template
changed the eventlistner from arrow function to eventlistner. fix: 71#
This reverts commit 5246c2d.
changed the eventlistner from arrow function to eventlistner. fix: hngprojects#71
shalomtaiwo
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Thank You |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the deactivation email template that is implemented as a component and takes in an object deactivationDetails that includes;
name => the name of the user
email => the email of the user
dateTime => the date and time of deactivation
**Closes #71 **
Changes proposed
What were you told to do?
I was to implement a deactivation email template
#71
What did you do?
I downloaded and later uploaded the assets in the figma file
I created a deactivation email tepmplates folder which I included the component file and the test file
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos