Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hng 150 create pricing cards displayed in pricing page #226

Merged
merged 10 commits into from
Jul 22, 2024

Conversation

Martin-IJ
Copy link
Collaborator

Description

Closes #150

Changes proposed

What were you told to do?

Create a pricing card component for displaying a pricing plan

What did you do?

Created a dynamic pricing card component and displayed it in the pricing page. The component is mobile responsive and uses props for customization of background color, border color, and text content. The component also includes action buttons using the shadcn button component.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Link to the design

https://www.figma.com/design/VEItfX6St5NSAqqNHImcxD/HNG-Boilerplate-Designs?node-id=4-20774&t=6FU5xxnRLovCtQ8K-1

Screenshots/Videos

SCR-20240720-qrzv

Copy link
Collaborator

@SirhmVFX SirhmVFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run pnpm lint:fix fix your lint issues

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hard code tailwind values

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded taillding values

@mrcoded mrcoded merged commit f00f6b0 into hngprojects:dev Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] External Static Pages > Pricing Page > Pricing Plans > Pricing plans card component
3 participants