Feat/hng-124 #207
Feat/hng-124 #207
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·········· with ········
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <unicorn/prevent-abbreviations> reported by reviewdog 🐶
Please rename the variable e. Suggested names are: error, event_. A more descriptive name will do too.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ············ with ··········
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace State,·IFormError with Error,·IFormState
🚫 [eslint] <unicorn/no-null> reported by reviewdog 🐶
Use undefined instead of null.
🚫 [eslint] <unicorn/no-null> reported by reviewdog 🐶
Use undefined instead of null.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
🚫 [eslint] <unicorn/prevent-abbreviations> reported by reviewdog 🐶
The variable Props should be named Properties. A more descriptive name will do too.
🚫 [eslint] <unicorn/prevent-abbreviations> reported by reviewdog 🐶
Please rename the variable e. Suggested names are: error, event_. A more descriptive name will do too.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace bg-white·text-base·text-black·outline-0·rounded-md with rounded-md·bg-white·text-base·text-black·outline-0
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace w-full·h-[80px]·border·border-[#DC2626]·outline-0·bg-white·px-2·placeholder:text-[#C2C2C2]·placeholder:text-sm·rounded-md·text-wrap with h-[80px]·w-full·text-wrap·rounded-md·border·border-[#DC2626]·bg-white·px-2·outline-0·placeholder:text-sm·placeholder:text-[#C2C2C2]
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ⏎export·default·function·Index()·{⏎ with export·default·function·Index()·{
hng_boilerplate_remix/app/routes/_index.tsx
Lines 13 to 15 in 17c448b
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
app/components/constant/index.tsx
Outdated
| }; | ||
|
|
||
| export const defaultFormError: IFormError = { | ||
| [FormField.bio]: null, |
There was a problem hiding this comment.
🚫 [eslint] <unicorn/no-null> reported by reviewdog 🐶
Use undefined instead of null.
app/components/constant/index.tsx
Outdated
| }; | ||
|
|
||
| export const defaultAlert: { message: string | null; classType?: string } = { | ||
| message: null, |
There was a problem hiding this comment.
🚫 [eslint] <unicorn/no-null> reported by reviewdog 🐶
Use undefined instead of null.
app/components/textarea/index.tsx
Outdated
| placeholder?: string; | ||
| disabled?: boolean; | ||
| error?: string | null; | ||
| handleChange: (e: React.ChangeEvent<HTMLTextAreaElement>) => void; |
There was a problem hiding this comment.
🚫 [eslint] <unicorn/prevent-abbreviations> reported by reviewdog 🐶
Please rename the variable e. Suggested names are: error, event_. A more descriptive name will do too.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
app/components/bio/index.tsx
Outdated
| } else { | ||
| setFormError({ | ||
| ...formError, | ||
| [key]: null, |
There was a problem hiding this comment.
🚫 [eslint] <unicorn/no-null> reported by reviewdog 🐶
Use undefined instead of null.
app/components/bio/index.tsx
Outdated
| name={FormField.bio} | ||
| value={formState[FormField.bio]} | ||
| error={formError[FormField.bio]} | ||
| handleChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => |
There was a problem hiding this comment.
🚫 [eslint] <unicorn/prevent-abbreviations> reported by reviewdog 🐶
Please rename the variable e. Suggested names are: error, event_. A more descriptive name will do too.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…remix into feat/HNG-124-Settings-Pages-Profile-Settings-implement-custom-extarea-with-validation-and-character-count
|
All resolved and fixed |
task-124 settings pages profile settings implement custom text area with validation and character count