Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/13 organization settings roles and permission page implement create role modal #190

Conversation

JO-YE
Copy link
Collaborator

@JO-YE JO-YE commented Jul 20, 2024

Ticket/Issue number

#13

Task

  • Create a modal component
  • Add a title "Create Role"
  • Add an input field for the name with the placeholder "e.g: IT Staff"
  • Add an input field for the description with the placeholder "describe role"
  • Add a "Cancel" button
  • Add a "Create Role" button
  • Ensure the modal follows brand colors and design
  • Ensure the modal is responsive

Screenshot of Create Role Modal Implementation

create_role_modal

Using-Shadcn-modal

Figma Link

@JO-YE JO-YE requested a review from oreoluwa212 July 20, 2024 10:24
@chumex412 chumex412 requested review from chumex412 and removed request for oreoluwa212 July 20, 2024 18:52
app/components/ui/create-role-modal.tsx Show resolved Hide resolved
@JO-YE
Copy link
Collaborator Author

JO-YE commented Jul 21, 2024

this branch "JO-YE:feat/13-organization-settings-roles-and-permission-page-implement-create-role-modal" is updated with the changes

@JO-YE JO-YE requested a review from chumex412 July 21, 2024 15:50
@shalomtaiwo shalomtaiwo self-requested a review July 21, 2024 16:41
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@shalomtaiwo shalomtaiwo removed the request for review from chumex412 July 21, 2024 16:43
@shalomtaiwo shalomtaiwo merged commit aa07b75 into hngprojects:dev Jul 21, 2024
1 check passed
@JO-YE
Copy link
Collaborator Author

JO-YE commented Jul 21, 2024

Thank you @shalomtaiwo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants