Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/53 FAQ questions form #123

Closed
wants to merge 20 commits into from
Closed

feat/53 FAQ questions form #123

wants to merge 20 commits into from

Conversation

abdulmalikyusuf
Copy link
Collaborator

@abdulmalikyusuf abdulmalikyusuf commented Jul 19, 2024

Developed an additional questions form where users can submit specific inquiries or questions that are not addressed in the FAQs section. The form includes fields for user's name, email address, phone number, and inquiry. Also implemented form validation.

Figma link

localhost_5173_

@abdulmalikyusuf abdulmalikyusuf changed the title Feat/53 questions form feat/53 FAQ questions form Jul 19, 2024
@chumex412
Copy link
Contributor

Resolve the conflicts

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use global colors, don't hardcode the colors

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, will change that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add this variable to the globals css file: --primary: 25 95% 53% //hsl value. I need it as the primary color'

@oreoluwa212
Copy link

I dont see your tests screenshots

Copy link

@oreoluwa212 oreoluwa212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a video too of your components working after you pulled from dev

@abdulmalikyusuf
Copy link
Collaborator Author

I dont see your tests screenshots

From the task posted on slack, only the next.js repo was to be tested and the packages for testing (vitest and others) are not included in the repository

@abdulmalikyusuf abdulmalikyusuf deleted the feat/53-questions-form branch July 21, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants