-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/HNG-17-success-page-for-magic-link #106
Closed
oyin-systems
wants to merge
39
commits into
hngprojects:main
from
oyin-systems:feat/HNG-17-success-page-for-magic-link
Closed
feat/HNG-17-success-page-for-magic-link #106
oyin-systems
wants to merge
39
commits into
hngprojects:main
from
oyin-systems:feat/HNG-17-success-page-for-magic-link
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remix into feat/47-component-datacard
…rantex/hng_boilerplate_remix into feat/47-component-datacard
Please resolve this PR's conflicts |
…-datacard Feat/47 component datacard
initialized staging dir
Merge pull request hngprojects#203 from hngprojects/dev
install pnpm lock file
…page-for-magic-link
Removed React import
I just did that, please check again. |
…ipts-to-pnpm Change deploy scripts to pnpm
Use pnpm lint instead
chumex412
requested review from
chumex412
and removed request for
kelani34 and
Samadeen
July 20, 2024 17:27
chumex412
requested changes
Jul 20, 2024
@chumex412 I've done the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The changes in this pull request aim to implement the successful login with magic link page as shown in the design.
Link to Design File
Figma File
Screenshot of my implementation