Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] COMPONENTS: Side Navigation bar (MOBILE) #105

Merged
merged 118 commits into from
Jul 22, 2024
Merged

[FEAT] COMPONENTS: Side Navigation bar (MOBILE) #105

merged 118 commits into from
Jul 22, 2024

Conversation

ikennarichard
Copy link
Contributor

@ikennarichard ikennarichard commented Jul 19, 2024 •
edited
Loading

[FEAT] COMPONENTS: Side Navigation bar (MOBILE)

For this project I implemented the following features:

  • Added responsive sidebar component.
  • Implemented dark mode and light mode styles.
  • Added toggle button for dark mode/light mode.
  • Styled sidebar to highlight the active menu item.
  • Ensured compliance with brand design guidelines.
  • Issue
  • Dev Mode Link
  • lint-result
  • sidebar-snapshot-1-dark
  • sidebar-snapshot-1-light
  • sidebar-snapshot-2-light
  • sidebar-snapshot-2-dark
  • snapshot3-close
  • snapshot3-open

@ikennarichard ikennarichard changed the base branch from main to dev July 19, 2024 16:44
shalomtaiwo
shalomtaiwo requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can the mobile nav scroll with the rest of the pages.

If it's a sidenav like this, it should be fixed and not affect the structure of the page either.

When on mobile, how would I view my full page if the mobile nav is covering a bit of the main content.

image

@ikennarichard
chore(HNG-5): fix lint issues
cd71840
@ikennarichard
feat(HNG-5): add bg on hover
23e49b2
@ikennarichard
chore(HNG-5): modify expanded
3cffcb9
@ikennarichard
chore(HNG-5): fix spacing issues
49751bc
@ikennarichard
Merge branch 'master' of https://github.com/ikennarichard/hng_boilerp…
42545e1 
…late_remix into feat/HNG-5-create-mobile-side-navigation-bar
@ikennarichard
fix(HNG-5): fix lint issues
854b125
@ikennarichard
Merge branch 'master' of https://github.com/ikennarichard/hng_boilerp…
e55a335 
…late_remix into feat/HNG-5-create-mobile-side-navigation-bar
@ikennarichard
Merge branch 'master' of https://github.com/ikennarichard/hng_boilerp…
67e9d67 
…late_remix into feat/HNG-5-create-mobile-side-navigation-bar
@ikennarichard
Merge branch 'master' of https://github.com/ikennarichard/hng_boilerp…
b8572e4 
…late_remix into feat/HNG-5-create-mobile-side-navigation-bar
@ikennarichard
Merge branch 'master' of https://github.com/ikennarichard/hng_boilerp…
0f88ee1 
…late_remix into feat/HNG-5-create-mobile-side-navigation-bar
shalomtaiwo
shalomtaiwo requested changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@shalomtaiwo shalomtaiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for conflicts

@ikennarichard
Copy link
Contributor Author

@shalomtaiwo ok thank you

@ikennarichard
Copy link
Contributor Author

@shalomtaiwo I've corrected the conflicts

@mrcoded mrcoded merged commit 96bbd25 into hngprojects:dev Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalomtaiwo shalomtaiwo shalomtaiwo requested changes

@mrcoded mrcoded mrcoded approved these changes

@chumex412 chumex412 Awaiting requested review from chumex412

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikennarichard @chumex412 @psalm987 @mrcoded @shalomtaiwo