fix: Removed email change from user and profile update, added separate route for recovery email update #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse, used background_tasks for emailing
|
kindly review |
trevorjob
approved these changes
Aug 23, 2024
This was
linked to
issues
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request aims to remove the change of email from /users and /profile endpoint. The change of user email is now moved to PUT /profile, and a user email can only be changed from email confirmation for security reason and to ensure data integrity.
Description
This Pull request aims to remove the change of email from /users and /profile endpoint. The change of user email is now moved to PUT /profile, and a user email can only be changed from email confirmation for security reason and to ensure data integrity.
Related Issue (Link to issue ticket)
[FIX] Include the addition of social links in the profile update #935
[FIX] Remove the email from fields to be updated on users profile. #937
[FIX] Create a different endpoint to handle change of emails for users. #938
[FIX] [ANCHOR: BE PYTHON] Create a different endpoint to handle change of emails for users. #912
[FIX] [ANCHOR: BE PYTHON] Remove the email from fields to be updated on users profile. #914
[FIX] [ANCHOR: BE PYTHON] Include the addition of social links in the profile update #915
Motivation and Context
How Has This Been Tested?
This has been tested with pytest and postman.
Screenshots (if appropriate - Postman, etc):
Types of changes
Checklist: