-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed the password-reset endpoint #884
Closed
johnson-oragui
wants to merge
13
commits into
hngprojects:dev
from
johnson-oragui:fix/reset-password
Closed
fix: Fixed the password-reset endpoint #884
johnson-oragui
wants to merge
13
commits into
hngprojects:dev
from
johnson-oragui:fix/reset-password
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_password_token.user_id
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 19:59 — with
GitHub Actions
Failure
johnson-oragui
requested review from
trevorjob
and removed request for
trevorjob
August 13, 2024 20:01
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 20:22 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 20:34 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 20:44 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 20:47 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 20:55 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 21:31 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 21:31 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 21:35 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 22:43 — with
GitHub Actions
Failure
johnson-oragui
had a problem deploying
to
preview
August 13, 2024 22:45 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix corrects the the previous implementation where users are not appropriately sent a link/valid link when they request for a password change.
Description
This fix corrects the the previous implementation where users are not appropriately sent a link/valid link when they request for a password change. With the changes done, users can now receive mails regarding heir change of password.
Related Issue (Link to issue ticket)
Motivation and Context
Users/Clients should be able to changes/reset their password when they have forgotten it or can no longer sign for some security reason.
How Has This Been Tested?
This has been tested with pytest and postman.
Screenshots (if appropriate - Postman, etc):
Reset token sent to user successfully
reset token received in user email
user successfully changes password
user tries to reuse token
passwords validations
Types of changes
Checklist: