Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: refactor rndpoints to ratch response rtructure with NestJS repository #829

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

MikeSoft007
Copy link
Collaborator

Description

This PR refactors the existing FastAPI endpoints to align with the response structure used in the associated NestJS repository. The changes ensure consistent API response formats across both repositories.

Related Issue (Link to issue ticket)

Motivation and Context

This change is required to maintain consistency in API responses across different repositories, particularly between the FastAPI and NestJS implementations. This helps in standardizing the data contracts used across different services and makes the integration process smoother.

How Has This Been Tested?

  • Refactored endpoints have been tested locally using Postman to ensure that they return the expected response format.
  • Unit tests have been updated and executed successfully to verify that the changes do not break existing functionality.
  • Integration tests were conducted to validate the correct functioning of the application when interacting with other services.

Screenshots (if appropriate - Postman, etc):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joboy-dev joboy-dev merged commit 8271bfd into hngprojects:dev Aug 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants