Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update job #95

Closed
wants to merge 6 commits into from
Closed

Update job #95

wants to merge 6 commits into from

Conversation

RaphAlemoh
Copy link
Contributor

Description

  • Implement an Api endpoint to update a job post detail, incase of any omission in job details.

Related Issue (Link to Github issue)

Related issue to frontend
Related issue for Backend

Endpoints

  • api/v1/jobs/:id

Motivation and Context

Enable updating of a posted job details, incase of any error(typo, etc)

How Has This Been Tested?

  • The endpoint is accessible at api/v1/jobs/:id
  • The endpoint accept HTTP PATCH requests.
  • The endpoint check that the user has the appropriate permissions.
  • The endpoint validate all data passed in the body of the request
  • Checks if the Requests to the endpoint include a valid authentication token in the Authorization header. Authorization: Bearer
  • Given a request with a valid job post ID, when the user is authenticated and authorized, the system update the user with a status code of 200
  • Given a request with an invalid or non-existent user ID, when the user is authenticated and authorised, the system return a 404 Not Found status.

Unit tests

    All test cases passed.
  • Successful response with valid id
  • invalid job post id
  • Missing job post id
  • invalid request body
  • Appropriate status code

Screenshots (if appropriate)

UpdateJobTest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Ruthiejayjay
Copy link
Contributor

Fix merge conflicts

…hp_laravel_web into update-job

[Job Feature Conflict] Resovle  Job Conflict

Resolve api
Resolve jobfactory
Resolve Job Models
Resolve Jobcontroller
@RaphAlemoh
Copy link
Contributor Author

RaphAlemoh commented Jul 23, 2024

Fix merge conflicts

I've resolved it and checked the test.

image

But it's failing to be accepted because other feature test cases failed like products requiring for price value error.

@RaphAlemoh RaphAlemoh closed this Jul 24, 2024
@RaphAlemoh RaphAlemoh deleted the update-job branch July 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants