Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct id for article creation response #600

Merged

Conversation

RaphAlemoh
Copy link
Contributor

Description

This pull request implements fix for the response to remove the null value in the article id after creation by an authenticated and authorised user. This endpoint uses the post method and ensures the user fill in the required fields.

Related Issue (Link to Github issue)

Feature #867

Endpoints
POST /api/v1/help-center/topics

Enable updating creation of help-center topics

How Has This Been Tested?

  • Successful response with valid article id
  • invalid request body
  • Appropriate status code

image

Screenshots (if appropriate - Postman, etc):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RaphAlemoh RaphAlemoh changed the title fix: return correct id for article fix: return correct id for article creation response Aug 25, 2024
@tulbadex tulbadex merged commit 19027f4 into hngprojects:dev Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants