Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product image upload #385

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Cytochrome123
Copy link
Contributor

@Cytochrome123 Cytochrome123 commented Aug 6, 2024

Description

This is a fix to the current implementation which treats the image url being sent with the payload instead of an actual image upload

Related Issue (Link to Github issue)

hngprojects/hng_boilerplate_nestjs#87

Motivation and Context

How Has This Been Tested?

  • Adjusted the previous test to handle the file upload too

Screenshots (if appropriate - Postman, etc):

Screenshot 2024-08-06 161542

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Dev-Tonia Dev-Tonia merged commit 88a03c8 into hngprojects:dev Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants