Merge branch 'hngprojects:dev' into login

hngprojects · Aug 16, 2024 · 5448bf9 · 5448bf9
2 parents 137ee0b + 90f7e2b
commit 5448bf9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/app/Http/Controllers/Api/V1/RoleController.php b/app/Http/Controllers/Api/V1/RoleController.php
@@ -284,6 +284,7 @@ public function show($org_id, $role_id)
 
             return response()->json([
                 'status_code' => Response::HTTP_OK,
+                'message' => "Roles fetched successfully",
                 'data' => [
                     'id' => $role->id,
                     'name' => $role->name,

diff --git a/app/Http/Requests/StoreRoleRequest.php b/app/Http/Requests/StoreRoleRequest.php
@@ -35,7 +35,7 @@ public function rules(): array
                 'exists:organisations,org_id',
                 Rule::unique('roles', 'org_id')->where('name', $this->input('role_name'))
             ],
-            'permissions_id' => 'required',
+            'permissions_id' => 'nullable',
         ];
     }
 

diff --git a/tests/Feature/ShowRoleTest.php b/tests/Feature/ShowRoleTest.php
@@ -138,3 +138,5 @@ public function testFetchNonExistentRole()
                  ]);
     }
 }
+
+?>
-Original file line number
+Diff line change
@@ Expand Up / @@ -138,3 +138,5 @@ public function testFetchNonExistentRole() @@
                      ]);
         }
     }
+    ?>