Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx: API integration and data mapping for job properties -team starlight #868

Closed
wants to merge 8 commits into from

Conversation

Thehanifah
Copy link

@Thehanifah Thehanifah commented Aug 1, 2024

Description

What were you told to do?

Fix API integration and data mapping for job properties

What did you do?

  • Introduced a salaryRange object to map API salary ranges (e.g., below_30k, 30k_to_50k) to more readable formats (e.g., below $30k, $30k - $50k).
  • Added a mapSalaryRange function to convert raw salary data to the mapped format.
  • Updated the handleViewDetails function to use the mapSalaryRange for the salary range passed in the query string when navigating to job details.

Career Card Component (src/components/common/CareerCard/CareerCard.tsx):

  • Added a similar salaryRange mapping object and mapSalaryRange function.
  • Applied the mapSalaryRange function to the amount property to ensure that salary ranges are displayed in the correct format on the job cards.

Check List

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR are clear and explain the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit message style matches our requested structure.
  • My code additions will not fail code linting checks or unit tests.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screenshot 2024-08-01 162211

@Thehanifah Thehanifah changed the title FIx: API integration and data mapping for job properties FIx: API integration and data mapping for job properties/team starlight Aug 1, 2024
@Maiqel1 Maiqel1 changed the title FIx: API integration and data mapping for job properties/team starlight FIx: API integration and data mapping for job properties -team starlight Aug 1, 2024
@Maiqel1 Maiqel1 requested a review from PrudentBird August 1, 2024 17:55
@Maiqel1
Copy link
Contributor

Maiqel1 commented Aug 1, 2024

you have conflicts, resolve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants