Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/password visibility #1533

Closed

Conversation

harjibbolar26
Copy link
Contributor

Description

This PR fixes the unavailability of the toggle icon in the password field and also fixes the text errors in the /dashboard/admin/settings/account route of the boilerplate for admins.

Closes #1216 and #1219 (similar PRs)

Changes proposed

What were you told to do?

Add "Eye Symbol" for Password Visibility Toggle in Password Input Fields
Text should Read "Confirm New Password and not "Confrim" Password

What did you do?

Added an icon for password visibility toggle and edited the text

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screenshot (253)

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.44% 781 / 5405
🔵 Statements 14.12% 783 / 5542
🔵 Functions 14% 215 / 1535
🔵 Branches 9.61% 226 / 2351
File CoverageNo changed files found.
Generated in workflow #560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add "Eye Symbol" for Password Visibility Toggle in Password Input Fields
3 participants