Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Implemented edit indicator when hovering over profile Icon in se… #1443

Closed

Conversation

Vaden89
Copy link
Contributor

@Vaden89 Vaden89 commented Aug 24, 2024

…ttings

Description

Closes #1381
Closes #1401

Changes proposed

What were you told to do?

Enhance the user experience by adding a camera icon to the circle profile picture placeholder. This icon should appear when users hover over or click the profile picture, indicating that they can upload or change their profile picture. The goal is to provide a clear, intuitive interface for users to update their profile images.
Profile setup information is not being saved after completion, resulting in an "invalid URL" error message even when all social media URLs are correct. We're all mostly on our mobile devices and should be able to navigate the boilerplate with it.

What did you do?

The camera icon appears centred within the circle profile picture when the user hovers over or clicks on the profile picture placeholder.
User profile information is saved successfully upon completion of the setup process.
There are no error messages related to invalid URLs when all URLs are accurate

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Screenshot (87)

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.67% 785 / 5349
🔵 Statements 14.35% 787 / 5481
🔵 Functions 14.18% 215 / 1516
🔵 Branches 9.93% 230 / 2314
File CoverageNo changed files found.
Generated in workflow #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PHP Profile Setup Save Issue [Enhancement]: Add Camera Icon to Circle Profile Picture for Uploading
2 participants