Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the social links to route to the sites. #1337

Merged

Conversation

maetheartist
Copy link
Contributor

Description

The social media icons on the "Contact Us" page are currently static images and do not direct users to the appropriate social media platforms. These icons should be made clickable and should link to the respective social media pages.
#1067 (comment)

Closes #issue_number_here
#1067 #1067 (comment)

Changes proposed

I made the social media links functional

What were you told to do?

Link All Social Media Icons to their Respective Social media pages on Contact Us Page

What did you do?

I made the links clickable and route to the sites

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • [x
    Screenshot (58)
    Uploading Screenshot (59).png…
    ] I am only making changes to files I was requested to.

Screenshots/Videos

Copy link
Contributor

github-actions bot commented Aug 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.7% 785 / 5338
🔵 Statements 14.38% 787 / 5470
🔵 Functions 14.18% 215 / 1516
🔵 Branches 9.98% 230 / 2303
File CoverageNo changed files found.
Generated in workflow #405

Copy link
Contributor

@billmal071 billmal071 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@incredible-phoenix246 incredible-phoenix246 merged commit 69b4c66 into hngprojects:dev Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants