Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Mismatch Error for New Password and Confirm New Password Fields on Password Settings page #1317

Conversation

abdulmalikyusuf
Copy link
Contributor

Description

This PR implements validation for the "New Password" and "Confirm New Password" fields to ensure that users are alerted immediately if the entries in these fields do not match. This enhancement prevents potential errors during password updates and improves the overall user experience. Additionally, the submit handler was rewritten to incorporate the new validation logic.

Closes #1268

Changes proposed

What were you told to do?

Implement real-time validation for the "New Password" and "Confirm New Password" fields to display an error message when the entries do not match.

What did you do?

  • Implemented real-time validation that triggers an error message when the entries in the "New Password" and "Confirm New Password" fields do not match.
  • Created a clear and concise error message that informs the user of the mismatch.
  • Ensured that the error message disappears once the two fields match.
  • Updated the submit handler to integrate the new validation logic.

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR are clear and explain the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit message style matches our requested structure.
  • My code additions will fail neither code linting checks nor unit tests.
  • I am only making changes to files I was requested to.

Screenshots/Videos

localhost_3000_dashboard_admin_settings_account (2)

Copy link
Contributor

github-actions bot commented Aug 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.7% 785 / 5338
🔵 Statements 14.38% 787 / 5470
🔵 Functions 14.18% 215 / 1516
🔵 Branches 9.98% 230 / 2303
File CoverageNo changed files found.
Generated in workflow #401

Copy link
Contributor

@billmal071 billmal071 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@incredible-phoenix246 incredible-phoenix246 merged commit 33aad3d into hngprojects:dev Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants