Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multiple timezones selected simultaenously #1288

Merged

Conversation

peter-abah
Copy link
Contributor

Description

Fix multiple timezones being selected simultaenously on Language & Region settings page of the Admin Dashboard.

Closes #1211

Changes proposed

What were you told to do?

On the Language & Region settings page of the Admin Dashboard, when the user attempts to select a single time zone from the dropdown, multiple entries are selected at the same time. This behavior makes it impossible for users to choose the correct time zone, leading to potential errors in saving changes.

Requirements:

  • Ensure that only one time zone can be selected at any given time.
  • Ensure proper selection and deselection behavior in the dropdown.
    Expected Outcome:
  • Only the selected time zone should be highlighted, with no other entries selected.

What did you do?

  • Change value of timezones used in Select component to be unique
  • sorted the timezones

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the dev branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/Videos

Before

image

After

image

Copy link
Contributor

github-actions bot commented Aug 23, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 14.69% 785 / 5341
🔵 Statements 14.37% 787 / 5474
🔵 Functions 14.17% 215 / 1517
🔵 Branches 10.02% 230 / 2294
File CoverageNo changed files found.
Generated in workflow #400

Copy link
Contributor

@billmal071 billmal071 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@incredible-phoenix246 incredible-phoenix246 merged commit 7577689 into hngprojects:dev Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [FE Anchor] Multiple Time-Zone Entries Selected Simultaneously in Language & Region Settings page
3 participants