-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh invite link #664
Open
coderoyalty
wants to merge
5
commits into
hngprojects:dev
Choose a base branch
from
coderoyalty:feat/refresh-invite-link
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bd5d4b7
feat: implement endpoint for refreshing an invitation
coderoyalty ff9c7bb
Merge branch 'dev' of https://github.com/hngprojects/hng_boilerplate_…
coderoyalty 047c4c4
test: add testcases for invitation refresh service
coderoyalty ef71120
Merge branch 'dev' of https://github.com/hngprojects/hng_boilerplate_…
coderoyalty e792ffb
refactor: added validation for organisation and invite id
coderoyalty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,9 +6,12 @@ import { | |
HttpException, | ||
HttpStatus, | ||
NotFoundException, | ||
Post, | ||
} from '@nestjs/common'; | ||
import { ApiBearerAuth, ApiOperation, ApiResponse, ApiTags } from '@nestjs/swagger'; | ||
import { InviteService } from './invite.service'; | ||
import { isUUID } from 'class-validator'; | ||
import { CustomHttpException } from '../../helpers/custom-http-filter'; | ||
|
||
@ApiBearerAuth() | ||
@ApiTags('Organisation Invites') | ||
|
@@ -41,4 +44,29 @@ export class InviteController { | |
} | ||
} | ||
} | ||
|
||
@Post(':orgId/invite/:inviteId/refresh') | ||
async refreshInvitation(@Param('orgId') orgId: string, @Param('inviteId') inviteId: string) { | ||
if (isUUID(orgId, 4)) { | ||
throw new CustomHttpException( | ||
{ | ||
status_code: 400, | ||
error: 'Bad Request', | ||
message: 'Invalid organisation ID format', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use constants where possible to make code cleaner and maintainable. Hardcoded strings just leaves room for errors |
||
}, | ||
400 | ||
); | ||
} else if (isUUID(inviteId, 4)) { | ||
throw new CustomHttpException( | ||
{ | ||
status_code: 400, | ||
error: 'Bad Request', | ||
message: 'Invalid organisation ID format', | ||
}, | ||
400 | ||
); | ||
} | ||
|
||
return await this.inviteService.refreshInvite(orgId, inviteId); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation is best handled in the controllers. Service layer is for your bussiness logic