feat: update job listing feature #623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the title, all small letters |
Heba-WebDev
approved these changes
Aug 5, 2024
alexindevs
changed the title
CFCIfe
reviewed
Aug 6, 2024
Comment on lines
+58
to
+60
| async update(@Param('id') id: string, @Body() updateJobDto: Partial<JobDto>) { | ||
| return this.jobService.update(id, updateJobDto); | ||
| } |
There was a problem hiding this comment.
Suggested change
| async update(@Param('id') id: string, @Body() updateJobDto: Partial<JobDto>) { | |
| return this.jobService.update(id, updateJobDto); | |
| } | |
| async updateJobById(@Param('id') id: string, @Body() updateJobDto: Partial<JobDto>) { | |
| return this.jobService.updateJobById(id, updateJobDto); | |
| } |
CFCIfe
reviewed
Aug 6, 2024
| @@ -69,6 +69,27 @@ export class JobsService { | |||
| data: job, | |||
| }; | |||
| } | |||
|
|
|||
| async update(id: string, updateJobDto: Partial<JobDto>) { | |||
There was a problem hiding this comment.
Suggested change
| async update(id: string, updateJobDto: Partial<JobDto>) { | |
| async updateJobById(id: string, updateJobDto: Partial<JobDto>) { |
Cobidex
reviewed
Aug 7, 2024
| @@ -48,4 +48,14 @@ export class JobsController { | |||
| async delete(@Param('id') id: string) { | |||
| return this.jobService.delete(id); | |||
| } | |||
|
|
|||
| @UseGuards(JobGuard) | |||
| @Patch('/:id') | |||
There was a problem hiding this comment.
No need for the forward slash
| @ApiResponse({ status: 200, description: 'Job updated successfully' }) | ||
| @ApiResponse({ status: 403, description: 'You do not have permission to perform this action' }) | ||
| @ApiResponse({ status: 404, description: 'Job not found' }) | ||
| async update(@Param('id') id: string, @Body() updateJobDto: Partial<JobDto>) { |
There was a problem hiding this comment.
Add UUID validation pipe to ensure id is of type UUID string.
| async update(id: string, updateJobDto: Partial<JobDto>) { | ||
| const job = await this.jobRepository.findOne({ where: { id } }); | ||
| if (!job) { | ||
| throw new NotFoundException({ |
There was a problem hiding this comment.
Use provided custom http exception handler
| throw new NotFoundException({ | ||
| status_code: 404, | ||
| status: 'Not found Exception', | ||
| message: 'Job not found', |
There was a problem hiding this comment.
Better to use constants where possible. This makes code cleaner and maintainable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an API endpoint to update job post details, allowing users to modify existing job listings in case of omissions or errors.
Changes
api/v1/jobs/:idupdatemethodTechnical Details
Endpoint:
PATCH api/v1/jobs/:idAuthentication: Bearer token required in Authorization header
Request body:
{ "title": "Software Engineer", "description": "Responsible for developing and maintaining web applications.", "location": "New York, NY", "deadline": "2024-12-31T23:59:59Z", "salary_range": "30k_to_50k", "job_type": "full-time", "job_mode": "remote", "company_name": "Tech Corp" }Note: All fields are optional for updates. Only provided fields will be updated.
Successful response (200 OK):
{ "message": "Job details updated successfully", "status_code": 200, "data": { "title": "Software Engineer", "description": "Responsible for developing and maintaining web applications.", "location": "New York, NY", "deadline": "2024-12-31T23:59:59Z", "salary_range": "30k_to_50k", "job_type": "full-time", "job_mode": "remote", "company_name": "Tech Corp", "is_deleted": false } }Error response (400 Bad Request):
{ "status_code": 400, "message": ["validation error message"], "error": "Bad Request" }Testing
updatemethodChecklist
api/v1/jobs/:idupdatemethodRelated Issues
Closes #158