Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 err handling for fetch all help center topics #290

Merged

Conversation

uloamaka
Copy link
Contributor

@uloamaka uloamaka commented Aug 7, 2024

Description

Fixed the error handling to properly return 404 error when no topic has been created priorly.

API DOC LINK

Related Issue (Link to Github issue)

#270

How Has This Been Tested?

Yes, the test case ensures it return proper error of 404, when there is no help center topics from the DB, while maintain the main functionality of fetch all help center topics if it is present on the DB.

Screenshots (if appropriate - Postman, etc):

Screenshot (356)

WHEN NO TOPICS IS PRESENT:
Screenshot (355)

WHEN THERE IS A TOPIC
Screenshot (354)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Micah-Shallom Micah-Shallom self-requested a review August 7, 2024 18:49
Copy link
Contributor

@Micah-Shallom Micah-Shallom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix accepted

@Micah-Shallom Micah-Shallom merged commit c0492f3 into hngprojects:dev Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants