Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: add new line to .env creation step #265

Merged

Conversation

vicradon
Copy link
Contributor

@vicradon vicradon commented Aug 4, 2024

This new line addition ensures that environment variables not defined in the app-sample.env get preppended with new lines before they are added

Description

  1. I ensured that I prepend a new line before each new field that is to be added to the .env file in the deploy_app script

Related Issue (Link to Github issue)

How Has This Been Tested?

Screenshots (if appropriate - Postman, etc):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This new line addition ensures that environment variables not defined in the app-sample.env get preppended with new lines before they are added
@vicradon vicradon requested a review from Cyberguru1 August 4, 2024 11:54
@Cyberguru1 Cyberguru1 merged commit 4cc30d9 into hngprojects:dev Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants