fix: 404 err handling for fetch all help center topics

hngprojects · Aug 7, 2024 · 743a4e8 · 743a4e8
1 parent 01d53de
commit 743a4e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/controller/helpcenter/helpcenter.go b/pkg/controller/helpcenter/helpcenter.go
@@ -76,10 +76,10 @@ func (base *Controller) FetchAllTopics(c *gin.Context) {
 	topics, paginationResponse, err := service.GetPaginatedTopics(c, base.Db.Postgresql)
 	if err != nil {
 		if err == gorm.ErrRecordNotFound {
-			rd := utility.BuildErrorResponse(http.StatusNotFound, "error", "No Job post not found", err, nil)
+			rd := utility.BuildErrorResponse(http.StatusNotFound, "error", "Topics not found", err, nil)
 			c.JSON(http.StatusNotFound, rd)
 		} else {
-			rd := utility.BuildErrorResponse(http.StatusInternalServerError, "error", "Failed to fetch job post", err, nil)
+			rd := utility.BuildErrorResponse(http.StatusInternalServerError, "error", "Failed to fetch topics", err, nil)
 			c.JSON(http.StatusInternalServerError, rd)
 		}
 		return

diff --git a/services/helpcenter/helpcenter.go b/services/helpcenter/helpcenter.go
@@ -40,6 +40,11 @@ func GetPaginatedTopics(c *gin.Context, db *gorm.DB) ([]HelpCntSummary, postgres
 	if err != nil {
 		return nil, paginationResponse, err
 	}
+
+	if len(helpCnts) == 0 {
+		return nil, paginationResponse, gorm.ErrRecordNotFound
+	}
+
 	var topicSummaries []HelpCntSummary
 	for _, Hlp := range helpCnts {
 		summary := HelpCntSummary{