-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restore User Subscription #510
Open
Nainah23
wants to merge
18
commits into
hngprojects:dev
Choose a base branch
from
Nainah23:feat/SUB-Restore_Deleted_Subscription
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Restore User Subscription #510
Nainah23
wants to merge
18
commits into
hngprojects:dev
from
Nainah23:feat/SUB-Restore_Deleted_Subscription
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressjs into feat/SUB-Restore_Deleted_Subscription
…ressjs into feat/SUB-Restore_Deleted_Subscription
…b.com/Nainah23/hng_boilerplate_expressjs into feat/SUB-Restore_Deleted_Subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue/Linear Ticket
Changes Proposed
Summary of Changes
src/controllers/NewsLetterSubscriptionController.ts
to include the new API endpoint for restoring deleted newsletter subscriptions.restoreSubscription
insrc/services/newsLetterSubscription.service.ts
to handle the restoration logic.src/routes/newsLetterSubscription.ts
to include the new route for the restore functionality.src/models/newsLetterSubscription.ts
to support active/inactive status of subscriptions.newsLetterSubscription.spec.ts
, covering success cases, invalid ID scenarios, and unauthorized access.Notes
NewsLetterSubscriber
model, particularly ifisActive
field is added.Testing
Check List (Check all the applicable boxes)
🚨Please review the [style guide for contributing](add link here) and [guidelines for contributing](add link here) to this repository.