Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial workflow setup #24

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Initial workflow setup #24

merged 2 commits into from
Jul 19, 2024

Conversation

kalio007
Copy link
Contributor

This is an initial GitHub workflow for my team

Copy link
Contributor

@Idimmusix Idimmusix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kalio007 there are some issues with your deployment

  1. DRY: you repeated Checkout code and install dependencies step
  2. your code is running on the github-actions default directrory; kindly set it up to run in a directory where it won't change easily

@kalio007 kalio007 requested a review from Idimmusix July 19, 2024 23:14
Copy link
Contributor

@Idimmusix Idimmusix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not complete yet, but good

@Idimmusix Idimmusix merged commit c243880 into hngprojects:dev Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants