-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker #64
base: master
Are you sure you want to change the base?
Update Docker #64
Conversation
@hnesk as you can see I am trying to get CI working again, but there are lots of problems in core ... One thing I keep stumbling over here is a test that I don't quite understand how it could ever have worked and why it is included here: browse-ocrd/tests/model/test_document.py Lines 182 to 189 in ca11972
Basically, this must fail, because
EDIT Now I understand. So this does yield an exception in core, but that is supposed to be caught in ocrd_browser, so the actual function returns none. Which it does – just the pytest output is confusing (because the whole stack trace is shown prior to "ok"). Also, I think I found the cause of the other failures: some of your test datasets still contained the old Let's hope this fixes CI 🤞 |
No description provided.