APIS-7016 Fix 'LaxEmailAddress' in audit detail (#495)

hmrc · May 16, 2024 · d4f6441 · d4f6441
1 parent 0f48391
commit d4f6441
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/uk/gov/hmrc/thirdpartyapplication/services/AuditService.scala b/app/uk/gov/hmrc/thirdpartyapplication/services/AuditService.scala
@@ -426,7 +426,7 @@ object AuditHelper {
       "applicationId"          -> app.id.value.toString,
       "applicationName"        -> app.name,
       "upliftRequestedByEmail" -> app.state.requestedByEmailAddress.getOrElse("-"),
-      "applicationAdmins"      -> app.admins.map(_.emailAddress).mkString(", ")
+      "applicationAdmins"      -> app.admins.map(_.emailAddress.text).mkString(", ")
     )
 
   def calculateAppChanges(previous: StoredApplication, updated: StoredApplication) = {

diff --git a/test/uk/gov/hmrc/thirdpartyapplication/services/AuditServiceSpec.scala b/test/uk/gov/hmrc/thirdpartyapplication/services/AuditServiceSpec.scala
@@ -200,7 +200,7 @@ class AuditServiceSpec extends AsyncHmrcSpec with ApplicationStateUtil
         "applicationId"          -> appInTesting.id.value.toString,
         "applicationName"        -> appInTesting.name,
         "upliftRequestedByEmail" -> appInTesting.state.requestedByEmailAddress.getOrElse("-"),
-        "applicationAdmins"      -> appInTesting.admins.map(_.emailAddress).mkString(", ")
+        "applicationAdmins"      -> appInTesting.admins.map(_.emailAddress.text).mkString(", ")
       )
 
       val extraDetail       = questionsWithAnswers ++ declinedData ++ dates ++ counters ++ gatekeeperDetails